Fix duplicate households on 'Merge same household' exports #14443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@mattwire wanna check this - it was your bug |
|
test this please |
|
Thanks @eileenmcnaughton I'll get to this soon! |
|
Ok I've now tested this and am happy that it fixes the bug on the sites where it's been reported to me. |
|
thanks @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Merge same household was creating duplicate rows for each household, one for the "merged individuals" and one being the explicit household directly exported.
Alternative of #14116
Before
After
Technical Details
When exporting contacts with "Merge same household" a household record is created by merging the individual record. However, that household is also exported directly leading to two records for the same household.
If a household has no relationships then we do need to directly export.
Comments
@mattwire I managed to replicate this in a test but your fix didn't make it pass - wanna test this?
From Prev PR: